Add Freemium PIR Feature Flag #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
requested review from
THISISDINOSAUR and
ayoy
and removed request for
THISISDINOSAUR
6 tasks
ayoy
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
LGTM 👍 the non-green CI is a false negative. We allow up to 3 retries for each failing integration test, and in this case the second run was successful, however the test reporter recorded a failure and makes CI red. We have to live with it for now (the main success indicator is that the actual tests run job is green, and the test report is less relevant).
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 22, 2024
Task/Issue URL: https://app.asana.com/0/1206488453854252/1208052452067291/f iOS PR: duckduckgo/iOS#3261 macOS PR: duckduckgo/macos-browser#3129 What kind of version bump will this require?: Patch **Description**: Adds PIR Freemium Subfeature
samsymons
added a commit
that referenced
this pull request
Aug 25, 2024
…iption * main: (25 commits) Bump version to 1.103.0 (249) Bump version to 1.103.0 (248) Resolving automatic update edge cases (#3142) PIR Time-Based Pixel: 24 Opt-Out Request Success Rate (#2942) Freemium Local Package and Freemium State Implementation (#3118) Bump rexml from 3.3.3 to 3.3.6 (#3141) Filter out inaccessible tasks from release (#3133) Bump rexml from 3.2.9 to 3.3.3 (#3139) Bump version to 1.103.0 (247) Specify secrets for pr.yml where called from another workflow (#3137) Fix secrets usage in CI workflows (#3134) Adding info about how we improve our products to the README.md (#3135) Add Freemium PIR Feature Flag (#3129) Release notes page loading fix + Adding close button to the upgrade notification (#3094) App Configuration app group (#3132) Use code signing in CI tests workflows (#3125) 'track' rephrased to 'anonymously track' (#3121) Additional PIR opt out confirmation pixels (#3119) Logging refactoring #1 Subscription and Content Blocking (#3091) Update RemoteMessagingDebugMenu to work on a private-queue context (#3120) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206488453854252/1208052452067291/f
Tech Design URL:
CC:
Description: Adds PIR Freemium Feature Flag (and temporarily points at related BSK commit)
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation