Unify bookmarks context menu across different views #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group&align code, add MARK-s, fix naming, cleanup
…#3110) - Add "Open all in new tabs" menu items - Fix bookmarks menu not closed when nested bookmarks menu item (or open all action) selected
- Bookmarks drag&drop support unified to act the same way in different places of UI: drag&drop support moved to BookmarkDragDropManager - Implemented drag&drop support for the Bookmarks Bar menus
- Add keyboard controls support to Bookmarks Bar menu - Activate search by typing any letter in the Navigation Bar Bookmarks menu - Close search in the Navigation Bar Bookmarks menu first on Esc press - Switching between the search bar and the search results using keyboard in the Navigation Bar Bookmarks menu
Adjust Bookmarks Menu popover size when number of items changes
…anage Bookmarks cmd+opt+B key equivalent
jotaemepereira
requested changes
Aug 28, 2024
There was a problem hiding this comment.
@mallexxx This is looking good, but I found some issues. I’m requesting changes because I found the following:
- Tapping the three dots on a bookmark on the bookmarks manager does not open the menu
- The
Manage Bookmarksmenu item should be disabled when the menu is opened from a bookmark on the bookmarks manager (at the moment, it is enabled) - Adding a folder is not working as expected. If I have Folder > Bookmark, and I select the folder in the Bookmarks Manager and then tap the three dots to create a folder, the folder is created in the root while it should be created inside the Folder (this works correctly in the panel but not in the manager)
- If you have Folder > Bookmark and select the Bookmark menu and tap on
Move to endit will move it to the end but in the root folder, instead of moving it inside the current folder.
| @@ -75,7 +75,7 @@ | |||
| { | |||
| "identity" : "lottie-spm", | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/airbnb/lottie-spm.git", | |||
| "location" : "https://github.com/airbnb/lottie-spm", | |||
There was a problem hiding this comment.
🔍 This should be reverted
There was a problem hiding this comment.
I guess it shouldn‘t as it‘s without .git in Package.swift
ayoy
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
I've retested issues found by @jotaemepereira and reviewed the code added after his review. All looks good to me and everything works as expected now. Thanks a lot @mallexxx!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202406491309510/1207775978136617/f
Project: https://app.asana.com/0/1202406491309510/1207775978136617/f
Includes:
#3106
#3107
#3110
#3111
#3138
#3112
#3113
Description:
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation