Add Phishing Detection Interface Elements #3157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task/Issue URL: https://app.asana.com/0/1205922231854923/1207701941801991/f Tech Design URL: CC: **Description**: **Steps to test this PR**: 1. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
1 task
not-a-rootkit
added a commit
that referenced
this pull request
Aug 27, 2024
Task/Issue URL: https://app.asana.com/0/414709148257752/1207874749913488/f Tech Design URL: CC: Description: This PR updates the app to add WireGuard as a direct dependency, instead of inheriting it from BSK. The issue with the inheritance approach is that WireGuard was being implicitly included in targets that didn't need it, like the VPN agent and app.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f **Description**: Now logging is aligned with our guideline: https://app.asana.com/0/1202500774821704/1208001254061393/f - all OSLog wrappers removed - all os_log uses removed and replaced with Logger - ability to disable logs from the app removed - Local and shared Logger improved
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208077416568671/f Tech Design URL: Look at BSK branch **Description**: Adds Contextual Dax Dialogs
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208146974665104/f **Description**: Add missing pixel reporting for subscription related keychain access errors.
Task/Issue URL: https://app.asana.com/0/1203301625297703/1208137627434486/f Description: This change removes asana-extract-task-assignee action, replacing it with a fastlane action from the automation plugin.
…3109) Task/Issue URL: https://app.asana.com/0/1193060753475688/1208066081988374/f Tech Design URL: CC: Description: This PR allows internal users to swap to the staging VPN environment with a production subscription.
Task/Issue URL: https://app.asana.com/0/0/1208044141877984/f BSK PR: duckduckgo/BrowserServicesKit#945 iOS PR: duckduckgo/iOS#3242 Description Adds engagement pixels for VPN domain exclusions.
There was a problem hiding this comment.
We normally use SVG files
There was a problem hiding this comment.
This is just a copy+paste from the other Exclamation-16 asset we use in the repo but with inverted transparency so I kept it the same format as that one. Could convert to SVG if it's outdated.
Comment on lines
+448
to
+451
| static let phishingDetectionHeader = NSLocalizedString("phishing-detection.enabled.header", value: "Malicious Site Protection", comment: "Header for phishing site protection section in the settings page") | ||
| static let phishingDetectionIsEnabled = NSLocalizedString("phishing-detection.enabled.checkbox", value: "Allow DuckDuckGo to warn you before loading a webpage that has been flagged as malicious or fraudulent.", comment: "Checkbox that enables or disables the phishing detection feature in the browser") | ||
| static let phishingDetectionEnabledWarning = NSLocalizedString("phishing-detection.enabled.warning", value: "Disabling this feature can put your personal information at risk. Only do so if you fully understand the risk involved.", comment: "A description box to warn users away from disabling phishing protection") | ||
|
|
There was a problem hiding this comment.
If the copy has been approved should we should get translations for these otherwise will be a blocker
There was a problem hiding this comment.
I've kicked off the job to get these translated.
DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
Outdated
Show resolved
Hide resolved
Task/Issue URL: https://app.asana.com/0/1205591970852438/1206773442486707/f Tech Design URL: CC: **Description:** The VPN geoswitching logic currently doesn’t handle the case that a location becomes unavailable. We should fall back to the country, if a city isn’t available, or nearest if the country isn’t available. **Steps to test this PR:** 1. Edit the VPNLocationViewModel to hardcode an extra a location that doesn’t exist and present it on the UI. 2. Select the location and confirm 3. Check that the fallback logic follow that mentioned in the description. Sample: ``` let data = "{\"country\":\"vn\",\"cities\":[{\"name\":\"Hanoi\"}]}".utf8data let fakeLocation = try! JSONDecoder().decode(NetworkProtectionLocation.self, from: data) locations.append(fakeLocation) ``` **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
…es (#3165) Task/Issue URL: https://app.asana.com/0/1203301625297703/1208174218141374/f Tech Design URL: CC: Description: This PR updates the test report action to set check_retries to true, which will avoid reporting a failure when a test fails and then succeeds upon a retry.
Task/Issue URL: https://app.asana.com/0/0/1208179338963311/f **Description**: Add support for DuckPlayer onboarding on C-S-S
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208016223626978/f Updates to use the new C-S-S special error page for SSL errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208149630394249/f
Tech Design URL:
CC:
Description:
Add customization to address bar buttons and assets for exclamation as per designs.
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation