Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bookmarks sort UI tests #3162

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Aug 27, 2024

Task/Issue URL: https://app.asana.com/0/1204006570077678/1208153822177986/f
Tech Design URL:
CC:

Description

Adds UI tests for bookmarks sort:

  • Test that changing sort in the panel is reflected in the Bookmarks Manager page and vice versa
  • Test that manual, name ascending and name descending sorting work as expected (both in panel and manager)
  • Test that selected sorting is persisted through browser restarts

Steps to test this PR

  1. Run the BookmarkSortTests class
  2. Check the UI tests work.

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotaemepereira jotaemepereira force-pushed the juan/ui-testing-bookmarks-search branch 2 times, most recently from 7f19b10 to 33357fe Compare September 3, 2024 13:37
Base automatically changed from juan/ui-testing-bookmarks-search to main September 3, 2024 13:59
@jotaemepereira jotaemepereira force-pushed the juan/ui-testing-bookmarks-sort branch from ea47dab to e10eae4 Compare September 3, 2024 14:47
@jotaemepereira jotaemepereira merged commit 10359ba into main Sep 3, 2024
18 checks passed
@jotaemepereira jotaemepereira deleted the juan/ui-testing-bookmarks-sort branch September 3, 2024 15:01
samsymons added a commit that referenced this pull request Sep 6, 2024
* main: (28 commits)
  Fix bookmark sort UI tests failure (#3219)
  Add tests for DuckPlayer pixel calculation (#3216)
  Implement checkbox VPN exclusions UI (#3207)
  fix zoom updated (#3140)
  Bump version to 1.105.0 (255)
  Add DuckPlayer enrollment pixels (#3190)
  Update PeopleFinders to address broker changes (#3208)
  Bump BSK with C-S-S to 6.14.0 (#3209)
  Zoom PDF controls (#3204)
  Fix exception on Copy in Save dialog (#3205)
  Remove DuckPlayer onboarding animation (#3198)
  Fix wrong URL displayed for auth dialog (#3191)
  Bump version to 1.105.0 (254)
  UI Ship review feedback for Duck Player onboarding (#3186)
  Implement bookmarks sort UI tests (#3162)
  Add bookmarks search UI tests (#3161)
  Bug: Disable boomark reordering when searching (#3188)
  Bump version to 1.105.0 (253)
  Remote feature flag for New Tab Page Improvements (#3176)
  Fix bookmarks bar issues (#3187)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants