Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate asana-get-automation-subtask-id from GHA action to fastlane #3175

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Aug 30, 2024

Task/Issue URL: https://app.asana.com/0/0/1208137627434493/f

Description:
This change removes asana-get-automation-subtask-id action, replacing it with a fastlane action from the automation plugin.

Steps to test this PR:

  1. Verify that CI is green.
  2. Verify that this test workflow completes successfully. Verify that this Asana task's Automation subtask has 1 new comment and 1 new subtask. This workflow is here only to demonstrate that the fastlane action works.
  3. Review fastlane plugin PR.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from jaceklyp August 30, 2024 06:33
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be removed before merging :)

Copy link
Contributor

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

with:
access-token: ${{ inputs.access-token }}
task-url: ${{ inputs.task-url }}
shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, shell definition is needed for actions steps.

@ayoy ayoy force-pushed the dominik/fastlane-plugin-asana-get-automation-subtask-id branch from fee8415 to 7f2d1d6 Compare September 2, 2024 08:35
@ayoy ayoy assigned ayoy and unassigned jaceklyp Sep 2, 2024
@ayoy ayoy merged commit 6197607 into main Sep 2, 2024
13 checks passed
@ayoy ayoy deleted the dominik/fastlane-plugin-asana-get-automation-subtask-id branch September 2, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants