Remote feature flag for New Tab Page Improvements #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 2, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1207539163549338/f iOS PR: duckduckgo/iOS#3294 macOS PR: duckduckgo/macos-browser#3176 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: CC: **Description**: Adds a remote feature to control availability of New Tab Page Improvements. **Steps to test this PR**: See duckduckgo/iOS#3294. --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
samsymons
added a commit
that referenced
this pull request
Sep 6, 2024
* main: (28 commits) Fix bookmark sort UI tests failure (#3219) Add tests for DuckPlayer pixel calculation (#3216) Implement checkbox VPN exclusions UI (#3207) fix zoom updated (#3140) Bump version to 1.105.0 (255) Add DuckPlayer enrollment pixels (#3190) Update PeopleFinders to address broker changes (#3208) Bump BSK with C-S-S to 6.14.0 (#3209) Zoom PDF controls (#3204) Fix exception on Copy in Save dialog (#3205) Remove DuckPlayer onboarding animation (#3198) Fix wrong URL displayed for auth dialog (#3191) Bump version to 1.105.0 (254) UI Ship review feedback for Duck Player onboarding (#3186) Implement bookmarks sort UI tests (#3162) Add bookmarks search UI tests (#3161) Bug: Disable boomark reordering when searching (#3188) Bump version to 1.105.0 (253) Remote feature flag for New Tab Page Improvements (#3176) Fix bookmarks bar issues (#3187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207539163549338/f
Tech Design URL:
CC:
Description:
No functional/code changes in macOS, only BSK reference update.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation