Bug: Disable boomark reordering when searching #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ayoy
approved these changes
Sep 3, 2024
mallexxx
reviewed
Sep 3, 2024
| @@ -264,6 +264,13 @@ final class BookmarkOutlineViewDataSource: NSObject, BookmarksOutlineViewDataSou | |||
| } | |||
|
|
|||
| let destination = destinationNode.isRoot ? PseudoFolder.bookmarks : destinationNode.representedObject | |||
|
|
|||
| if isSearching { | |||
| let result = dragDropManager.validateDropWhileInSearchMode(info, to: destination) | |||
There was a problem hiding this comment.
should we just keep the change in scope of the BookmarkOutlineViewDataSource? It seems it‘s overcomplicating things and spreading the responsibilities to the class not really meant to deal with search – BookmarkDragDropManager.
Maybe let‘s just convert it to guard !isSearching || destination is BookmarkFolder else { return .none } (with a comment explaining why it is so), WDYT?
There was a problem hiding this comment.
I agree 👍🏼 . Addressed
jotaemepereira
force-pushed
the
juan/disable-reordering-when-searching
branch
from
055fcfd to
eeff9bc
Compare
jotaemepereira
force-pushed
the
juan/disable-reordering-when-searching
branch
from
eeff9bc to
0d6e37b
Compare
samsymons
added a commit
that referenced
this pull request
Sep 6, 2024
* main: (28 commits) Fix bookmark sort UI tests failure (#3219) Add tests for DuckPlayer pixel calculation (#3216) Implement checkbox VPN exclusions UI (#3207) fix zoom updated (#3140) Bump version to 1.105.0 (255) Add DuckPlayer enrollment pixels (#3190) Update PeopleFinders to address broker changes (#3208) Bump BSK with C-S-S to 6.14.0 (#3209) Zoom PDF controls (#3204) Fix exception on Copy in Save dialog (#3205) Remove DuckPlayer onboarding animation (#3198) Fix wrong URL displayed for auth dialog (#3191) Bump version to 1.105.0 (254) UI Ship review feedback for Duck Player onboarding (#3186) Implement bookmarks sort UI tests (#3162) Add bookmarks search UI tests (#3161) Bug: Disable boomark reordering when searching (#3188) Bump version to 1.105.0 (253) Remote feature flag for New Tab Page Improvements (#3176) Fix bookmarks bar issues (#3187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208204239267626/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation