Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phishing Detection Privacy Dashboard Entrypoint #3195

Merged
merged 22 commits into from
Sep 5, 2024
Merged

Phishing Detection Privacy Dashboard Entrypoint #3195

merged 22 commits into from
Sep 5, 2024

Conversation

not-a-rootkit
Copy link
Collaborator

@not-a-rootkit not-a-rootkit commented Sep 3, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208149630394249/f
Tech Design URL: https://app.asana.com/0/481882893211075/1207220724600204/f
CC:

Description:
Implement AddressBarButtons to reflect designs from https://app.asana.com/0/0/1207896057014803/f

Steps to test this PR:

  1. Visit privacy-test-pages.site/security/badware/phishing.html
  2. Ensure error page is shown
  3. Click through the warning
  4. Red alert circle should be shown for the privacy dashboard entrypoint button

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@duckduckgo duckduckgo deleted a comment from github-actions bot Sep 3, 2024
Base automatically changed from tespach/phishing-error-scheme to tespach/phishing-detection-integration September 5, 2024 10:57
@not-a-rootkit not-a-rootkit marked this pull request as ready for review September 5, 2024 11:30
SabrinaTardio
SabrinaTardio approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the new icon stays while navigating to a new page. Something we should check with product later on.
I left a small nit if you can be bothered.

DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift Outdated Show resolved Hide resolved
@not-a-rootkit not-a-rootkit merged commit a0f2843 into tespach/phishing-detection-integration Sep 5, 2024
11 of 12 checks passed
@not-a-rootkit not-a-rootkit deleted the tespach/phishing-privacy-dashboard branch September 5, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabrinaTardio SabrinaTardio SabrinaTardio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-a-rootkit @SabrinaTardio