Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DuckPlayer onboarding animation #3198

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Sep 3, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208215097981301/f

Description:
Remove DuckPlayer onboarding animation
Center dax logo with dialog

Steps to test this PR:

  1. Trigger the onboarding, make sure there's no animation when moving from modal A to modal B

@Bunn Bunn requested a review from afterxleep September 3, 2024 17:06
@Bunn Bunn merged commit 613a097 into release/1.105.0 Sep 4, 2024
26 of 27 checks passed
@Bunn Bunn deleted the bunn/duckplayer/remove-animation branch September 4, 2024 08:38
samsymons added a commit that referenced this pull request Sep 6, 2024
* main: (28 commits)
  Fix bookmark sort UI tests failure (#3219)
  Add tests for DuckPlayer pixel calculation (#3216)
  Implement checkbox VPN exclusions UI (#3207)
  fix zoom updated (#3140)
  Bump version to 1.105.0 (255)
  Add DuckPlayer enrollment pixels (#3190)
  Update PeopleFinders to address broker changes (#3208)
  Bump BSK with C-S-S to 6.14.0 (#3209)
  Zoom PDF controls (#3204)
  Fix exception on Copy in Save dialog (#3205)
  Remove DuckPlayer onboarding animation (#3198)
  Fix wrong URL displayed for auth dialog (#3191)
  Bump version to 1.105.0 (254)
  UI Ship review feedback for Duck Player onboarding (#3186)
  Implement bookmarks sort UI tests (#3162)
  Add bookmarks search UI tests (#3161)
  Bug: Disable boomark reordering when searching (#3188)
  Bump version to 1.105.0 (253)
  Remote feature flag for New Tab Page Improvements (#3176)
  Fix bookmarks bar issues (#3187)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants