Freemium PIR: Disable and Delete PIR If the Freemium Feature Is Disabled #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
force-pushed
the
pete/feature/pir-freemium-delete-data-on-feature-disable
branch
from
a6c9d8d to
9f1d6cd
Compare
ayoy
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
LGTM! All works well after I've read through the steps carefully 😅 Leaving just a single API naming comment. Thanks @aataraxiaa!
| /// | ||
| /// 1. Is eligible to purchase | ||
| /// 2. Is not a current subscriber | ||
| var isAPotentialPrivacyProSubscriber: Bool { |
There was a problem hiding this comment.
I'd remove the A from this name as we don't really use articles in symbol names :)
aataraxiaa
deleted the
pete/feature/pir-freemium-delete-data-on-feature-disable
branch
aataraxiaa
added a commit
that referenced
this pull request
Sep 10, 2024
…led (#3200) Task/Issue URL: https://app.asana.com/0/0/1208081037247881/f **Description**: This PR implements disabling of PIR and deletion of related data when: 1. The user had onboarded to Freemium AND 2. The feature flag is disabled
aataraxiaa
added a commit
that referenced
this pull request
Sep 18, 2024
…led (#3200) Task/Issue URL: https://app.asana.com/0/0/1208081037247881/f **Description**: This PR implements disabling of PIR and deletion of related data when: 1. The user had onboarded to Freemium AND 2. The feature flag is disabled
aataraxiaa
added a commit
that referenced
this pull request
Oct 8, 2024
…led (#3200) Task/Issue URL: https://app.asana.com/0/0/1208081037247881/f **Description**: This PR implements disabling of PIR and deletion of related data when: 1. The user had onboarded to Freemium AND 2. The feature flag is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208081037247881/f
Description: This PR implements disabling of PIR and deletion of related data when:
Testing Prerequisites
FreemiumPIRFeatureat line96freemiumset tointernal. Then use the debug menu to set a custom config to this, and refresh the configSteps to test this PR:
**TEST 1 - Onboard to Freemium Then Disable the Feature
Personal Information ScanfreemiumJSON Blob value todisabled, and refresh the configPersonal Information Scanitem should not be in the more options**TEST 2 - Onboard to Freemium, Then Purchase Privacy Pro, Then Disable the Feature
freemiumJSON Blob value tointernal, and refresh the configPersonal Information ScanfreemiumJSON Blob value todisabled, and refresh the configDefinition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation