Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CPM experiment #3534

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Clean up CPM experiment #3534

merged 7 commits into from
Nov 13, 2024

Conversation

muodov
Copy link
Member

@muodov muodov commented Nov 11, 2024

Task/Issue URL: https://app.asana.com/0/1206594217714678/1207420864578039/f
Tech Design URL:
CC:

Description:
This PR cleans up CPM filterlist experiment and enables filterlist for all users (still controlled by the remote config).

Steps to test this PR:

  1. make sure you're using remote config that enables "autoconsent -> filterlist" subfeature
  2. go to https://skyscanner.nl, ensure that the cookie pop-up is not visible.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@muodov muodov marked this pull request as ready for review November 12, 2024 13:59
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the BSK reference

@muodov muodov merged commit af2ca4b into main Nov 13, 2024
20 checks passed
@muodov muodov deleted the max/cleanup-cpm-experiment branch November 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants