Handle child to parent broker migration #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
commented
Dec 2, 2024
...Protection/Tests/DataBrokerProtectionTests/DataBrokerProfileQueryOperationManagerTests.swift
Show resolved
Hide resolved
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/JSON/kwold.com.json
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
...kages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerOperation.swift
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UI/UIMapper.swift
Outdated
Show resolved
Hide resolved
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DataBroker.swift
Outdated
Show resolved
Hide resolved
...kages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerOperation.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UI/UIMapper.swift # LocalPackages/DataBrokerProtection/Tests/DataBrokerProtectionTests/MapperToUITests.swift
|
How much work do you think writing an E2E test case for this would be? |
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/JSON/kwold.com.json
|
I'm not sure what to do with this PR, since in testing I can see that the DB state seems to be correct as expected, but I'm not seeing the UI bits that I should be |
THISISDINOSAUR
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208702228842632/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208796378141962/f
CC:
Description:
Supports child-to-parent-broker migration.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation