-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for conditional clicking #3623
Open
brianhall
wants to merge
12
commits into
main
Choose a base branch
from
bhall/support-conditional-clicking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhall
changed the title
Add conditional clicking
Add support for conditional clicking
Dec 4, 2024
I need something like this here, but keep getting stuck: // Explicitly encode `null` if `defaultClick` is nil
if let defaultClick = defaultClick {
try container.encode(defaultClick, forKey: .defaultClick)
} else {
try container.encodeNil(forKey: .defaultClick)
} |
brianhall
added
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
and removed
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
labels
Dec 12, 2024
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1208647902506360/f
Tech Design URL:
CC:
Description:
Adds support for conditional clicking of elements by adding “choices” and “default” keys to the click action.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
The easiest way to test whether the decoding is working is to setup one of the test files from the C-S-S integration tests as a fake broker:
file://
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/JSON
main
), then open the debug version of PIR: Debug Menu -> Personal Information Removal -> Run Personal Information Removal in Debug Mode.1965
, then select Test Broker in the list of brokers and click the Run button.window.location.href
and hit enter. You should see a url that ends with#1
, which means that the user was older than 45.1990
, when you dowindow.location.href
you should get a url that ends with#2
instead, indicating that the user is < 45.null
.window.location.href
should return a url with no#
at the end, meaning that nothing was clicked and no error was triggered.#1
hash at the end of the url), and step 7 should not return an error, but also not have any hash (e.g.#1
) at the end of the url.Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation