Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRCID Support when reporting crashes #3653

Merged
merged 14 commits into from
Dec 19, 2024
Merged

CRCID Support when reporting crashes #3653

merged 14 commits into from
Dec 19, 2024

Conversation

jdjackson
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1208592102886666/1208759541597499/f
Tech Design URL: https://app.asana.com/0/1208592102886666/1208660326715650/f

Description:
DO NOT MERGE - this is a draft for input, not ready to go live yet.

MacOS support for crash report cohort IDs (CRCIDs) when sending crash reports.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
To cause and report a crash:

  1. Launch the app and force a crash, which can be done from Debug (menu) → Simulate Crash → fatalError (or similar).
  2. Launch the app again (easiest with a debugger)
  3. You will be prompted to submit the crash. When submitting, watch logs for “crcid” and “crash” and you should see output from these changes confirming a CRCID is received and updated.
  4. Repeat steps 2-3 again, and you should see that the CRCID received initially is what’s submitted with the next crash.

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jdjackson jdjackson force-pushed the jjackson/crcid-support branch from ed81dbe to 4fd3cf9 Compare December 18, 2024 17:52
@jdjackson jdjackson marked this pull request as ready for review December 18, 2024 20:42
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jdjackson jdjackson merged commit ab35023 into main Dec 19, 2024
20 checks passed
@jdjackson jdjackson deleted the jjackson/crcid-support branch December 19, 2024 21:27
samsymons added a commit that referenced this pull request Dec 19, 2024
* main:
  CRCID Support when reporting crashes (#3653)
  Bump version to 1.119.0 (332)
  Update to Privacy Pro settings footer (#3679)
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
  Bump version to 1.118.1 (331)
  Set marketing version to 1.118.1
  [Release PR] Update VPN localization (#3675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants