Look up lowercased URLs in lowercased items dict #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I tested it and it looks good 👍🏼 .
@ayoy This findBookmark should be easy to test, can you add some unit tests related to this, so we are sure we will not have this issue ni the future?
|
@jotaemepereira let me work on unit tests separately and let's have this merged first to unblock UI tests. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208943052282180/f
Description:
This change fixes looking up bookmarks in the lowercased items dictionary by also lowercasing
the URL in question.
Steps to test this PR:
You can test manually by opening a mixed case URL such as https://pl.wikipedia.org/w/index.php?title=The_Mandalorian_%28sezon_1%29&oldid=75295490&veaction=edit and trying to bookmark it via context menu -> Bookmark Page. The bookmark icon in the address bar should be filled, indicating that the URL is now bookmarked.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation