Add 'locale' to report broken site params #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miasma13
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 12, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/414709148257752/1208827075841585/f iOS PR: duckduckgo/iOS#3717 macOS PR: duckduckgo/macos-browser#3661 What kind of version bump will this require?: Major **Description**: Add the "locale" param ID to the list of properties submitted in the Privacy Dashboard site breakage form. **Steps to test this PR**: See respective platform PRs. **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Alexey Martemyanov <[email protected]>
miasma13
force-pushed
the
michal/add-locale-to-report-broken-site-params
branch
from
10d6c47 to
b6ce770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1208827075841585/f
Description:
Add the "locale" param ID to the list of properties submitted in the Privacy Dashboard site breakage form.
Steps to test this PR:
To force report broken site form to be shown every time you can change https://github.com/duckduckgo/BrowserServicesKit/blob/b7f7ba99f7c77b576679eee426ddd80320dc74d8/Sources/PrivacyDashboard/ToggleReportingManager.swift#L104 to always return
trueDefinition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation