Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Safari import passwords instructions for macOS 15.2 #3671

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 17, 2024

Task/Issue URL: https://app.asana.com/0/1201462886803403/1208921574824172/f
Tech Design URL:
CC:

Description:
Update copy on the passwords data import flow in line with latest Safari updates from macOS 15.2

Steps to test this PR:

  1. Assuming you can’t easily toggle between macOS versions, feel free to tweak the if #available(macOS 15.2, *) { to a version that makes sense for your environment (it won’t affect the test steps which are just copy updates0
  2. Set up so that your macOS version and the if #available check match
  3. Start the Safari import data flow and confirm the copy on the Passwords import prompt matches the final copy from this task description: https://app.asana.com/0/38424471409662/1208966807789111/f
  4. Now set up so your macOS version is lower than theif #available check
  5. Start another Safari import, but this time confirm the copy is the original version

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 1b487f7

Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected @amddg44

@amddg44 amddg44 merged commit ca053a3 into main Dec 20, 2024
28 checks passed
@amddg44 amddg44 deleted the anya/safari-importer-copy-updates-macos152 branch December 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants