Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Verecor child sites to be parent sites #3678

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

brianhall
Copy link
Collaborator

@brianhall brianhall commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/608920331025329/1209014062691302/f
Tech Design URL:
CC:

Description:

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
1.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 01b7528

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 27, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2025

This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions.

@github-actions github-actions bot closed this Jan 4, 2025
@quanganhdo quanganhdo reopened this Jan 6, 2025
@github-actions github-actions bot removed the stale label Jan 7, 2025
Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jan 14, 2025
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing tests are unrelated.

@brianhall brianhall merged commit 0fd512d into main Jan 14, 2025
35 of 37 checks passed
@brianhall brianhall deleted the bhall/convert-verecor-child-sites-to-parents branch January 14, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants