Add support for background customization in HTML New Tab Page #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ML NTP is available
Task/Issue URL: https://app.asana.com/0/72649045549333/1208973375734052/f Description: This change adds support for displaying Freemium PIR banner in the HTML New Tab Page. The logic of FreemiumDBPPromotionViewCoordinator is updated so that the viewModel is a published property, updated whenever isHomePagePromotionVisible changes (which also means that it's nullified whenever the user dismisses or actions a banner).
ayoy
commented
Jan 8, 2025
DuckDuckGo/Freemium/DBP/Extensions/PromotionView+FreemiumDBP.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/HomePage/Model/HomePageSettings/CustomBackgrounds/GradientBackground.swift
Show resolved
Hide resolved
DuckDuckGo/HomePage/Model/HomePageSettings/CustomBackgrounds/GradientBackground.swift
Show resolved
Hide resolved
...ckages/NewTabPage/Sources/NewTabPage/CustomBackground/NewTabPageCustomBackgroundClient.swift
Outdated
Show resolved
Hide resolved
LocalPackages/NewTabPage/Sources/NewTabPage/NewTabPageActionsManager.swift
Show resolved
Hide resolved
LocalPackages/NewTabPage/Tests/NewTabPageTests/Helpers/MessageHelper.swift
Show resolved
Hide resolved
samsymons
reviewed
Jan 9, 2025
| @@ -117,6 +117,11 @@ final class DefaultHomePageNavigator: HomePageNavigator { | |||
| if let window = WindowControllersManager.shared.lastKeyMainWindowController { | |||
| let homePageViewController = window.mainViewController.browserTabViewController.homePageViewController | |||
| homePageViewController?.settingsVisibilityModel.isSettingsVisible = true | |||
|
|
|||
| if NSApp.delegateTyped.featureFlagger.isFeatureOn(.htmlNewTabPage) { | |||
There was a problem hiding this comment.
Question about the feature flag: I saw that the htmlNewTabPage feature has an isLaunched subfeature, but I didn't see it used anywhere yet. If there's any chance that you'll be using the rollouts array to roll this out, I'd use that instead, since top level features don't support rollouts. If not, then the current implementation is fine as-is.
(I've been meaning to post about this to the team since this detail bit us for another feature earlier this week.)
There was a problem hiding this comment.
Yes, I do plan to use the rollouts array and that was the reason for adding a subfeature :) it's just not implemented yet and will come in a separate PR.
samsymons
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208246350498758/f
Description:
This change connects HomePageSettingsModel to HTML New Tab Page.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation