-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
Assuming that testing step 3 is slightly wrong:
- popover should hide after 4s when mouse is out; popover shouldn‘t close when opened using the button in the address bar
-> It actually closes after 2 seconds from the address bar button
I left a few comments / questions
@@ -16,47 +16,10 @@ | |||
// limitations under the License. | |||
// | |||
|
|||
import SwiftUI | |||
import AppKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming we moved away from SwiftUI for positioning etc problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I couldn‘t make it look like on the design using SwiftUI
static let toolbarCloseIntervalItem = NSUserInterfaceItemIdentifier("toolbarCloseIntervalItem") | ||
} | ||
|
||
final class ZoomPopoverDebugMenu: NSMenu { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to allow reviewer to check which interval works best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, to be removed before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks great!
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208866166089091/f
Description:
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation