Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

fix and re-enable integration tests #3845

Closed
wants to merge 3 commits into from
+8 −7
Closed

fix and re-enable integration tests #3845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e599bd
fix and re-enable integration tests
SabrinaTardio Feb 7, 2025
9443610
exclude flaky tests
SabrinaTardio Feb 7, 2025
73e4936
exclude flaky tests
SabrinaTardio Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DuckDuckGo-macOS.xcodeproj/xcshareddata/xcschemes/macOS Browser App Store.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@
<Test
Identifier = "CBRCompileTimeReporterTests">
</Test>
<Test
Identifier = "ConfigurationManagerTests">
</Test>
<Test
Identifier = "FireproofingReferenceTests/testFireproofing()">
</Test>
Expand Down Expand Up @@ -145,9 +148,6 @@
<Test
Identifier = "AutoconsentIntegrationTests/testWhenAutoconsentDisabled_promptIsDisplayed()">
</Test>
<Test
Identifier = "ConfigurationManagerIntegrationTests/testTdsAreFetchedFromURLBasedOnPrivacyConfigExperiment()">
</Test>
<Test
Identifier = "CoreDataEncryptionTests/testSavingIncorrectValueTypes()">
</Test>
Expand Down
6 changes: 3 additions & 3 deletions DuckDuckGo-macOS.xcodeproj/xcshareddata/xcschemes/macOS Browser.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@
<Test
Identifier = "CBRCompileTimeReporterTests">
</Test>
<Test
Identifier = "ConfigurationManagerTests">
</Test>
<Test
Identifier = "PixelExperimentTests">
</Test>
Expand Down Expand Up @@ -180,9 +183,6 @@
<Test
Identifier = "AutoconsentIntegrationTests/testWhenAutoconsentDisabled_promptIsDisplayed()">
</Test>
<Test
Identifier = "ConfigurationManagerIntegrationTests/testTdsAreFetchedFromURLBasedOnPrivacyConfigExperiment()">
</Test>
<Test
Identifier = "CoreDataEncryptionTests/testSavingIncorrectValueTypes()">
</Test>
Expand Down
2 changes: 1 addition & 1 deletion IntegrationTests/Configurations/ConfigurationManagerIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ final class ConfigurationManagerIntegrationTests: XCTestCase {
// THEN
var newEtag = ContentBlocking.shared.trackerDataManager.fetchedData?.etag
XCTAssertNotEqual(etag, newEtag)
XCTAssertEqual(newEtag, "\"2ce60c57c3d384f986ccbe2c422aac44\"")
XCTAssertEqual(newEtag, "\"5c0f8d8cdcd80e3f26889323dae1dff9\"")

// RESET
_ = AppConfigurationURLProvider(customPrivacyConfiguration: AppConfigurationURLProvider.Constants.defaultPrivacyConfigurationURL)
Expand Down
1 change: 1 addition & 0 deletions UnitTests/Configuration/ConfigurationManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import Configuration
import Combine
import TrackerRadarKit

// Temporarily disabled because they are flaky in CI
final class ConfigurationManagerTests: XCTestCase {
private var operationLog: OperationLog!
private var configManager: ConfigurationManager!
Expand Down
Loading