This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Add unit tests for History View user script and fix reloading history #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jotaemepereira please note that HistoryViewDataProvider is not tested yet in this change. I'll provide tests for that class later. Thanks! |
jotaemepereira
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
@ayoy I’ve tested the feature and the unit tests looks good 👍🏼 .
| @@ -27,7 +27,7 @@ extension Array { | |||
| } | |||
|
|
|||
| func chunk(with limit: Int, offset: Int) -> [Element] { | |||
| guard !isEmpty, offset < count else { | |||
| guard !isEmpty, limit >= 0, offset >= 0, offset < count else { | |||
There was a problem hiding this comment.
❓ Did we have calls to the chunk method with negative values on limit and offset, is it something we should be worried about?
There was a problem hiding this comment.
Only if accidentally called with a negative value, which shouldn't be the case, but this function is ultimately called from JS, so better safe than sorry :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209365356928711
Description:
This change adds missing unit tests, adds event handling to History View (together with 2 pixels) and
fixes reloading history.
Steps to test this PR:
historyViewfeature flag.duck://history).Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation