Revert to smaller autoconsent bundle (without easylist rules) #3861
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/autoconsent-slim
branch
from
caabc48 to
081bca5
Compare
|
@muodov - that change is already in. Not sure why there is a failed test. Tests are passing for me locally. |
muodov
approved these changes
Feb 14, 2025
|
CLosing this, I'll make a PR in the new repo |
1 task
muodov
added a commit
to duckduckgo/apple-browsers
that referenced
this pull request
Feb 19, 2025
<!-- Note: This template is a reminder of our Engineering Expectations and Definition of Done. Remove sections that don't apply to your changes.⚠️ If you're an external contributor, please file an issue before working on a PR. Discussing your changes beforehand will help ensure they align with our roadmap and that your time is well spent. --> Task/Issue URL: https://app.asana.com/0/0/1209338591427795 Tech Design URL: CC: @sammacbeth ### Description We've decided to pause use of Easylist cosmetic filters in CPM. This means we can switch back to the smaller bundle for a slimmer userscript. This is a port from duckduckgo/macos-browser#3861 ### Testing Steps <!-- Assume the reviewer is unfamiliar with this part of the app --> 1. 2. ### Impact and Risks <!-- What's the impact on users if something goes wrong? High: Could affect user privacy, lose user data, break core functionality Medium: Could disrupt specific features or user flows Low: Minor visual changes, small bug fixes, improvement to existing features None: Internal tooling, documentation --> #### What could go wrong? <!-- Describe specific scenarios and how you've addressed them --> ### Quality Considerations <!-- Focus on what matters for your changes: - What edge cases exist? - How does this affect performance? - What monitoring have you added? - What documentation needs updating? - How does this impact privacy/security? --> ### Notes to Reviewer <!-- Anything specific you want reviewers to focus on --> ### Optional E2E tests**: - [ ] Run macOS PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. --- ###### Internal references: [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f) | [Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) | [Tech Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209338591427795
Tech Design URL:
CC:
Description:
We've decided to pause use of Easylist cosmetic filters in CPM. This means we can switch back to the smaller bundle for a slimmer userscript.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
1.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation