Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risky domains protection #3865

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Feb 13, 2025

Task/Issue URL: https://app.asana.com/0/1204186595873227/1209409234171914

Description: Adds risky domain protection to our VPN

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
DNS Settings Migration

  1. Run the app from main branch and set a custom DNS
  2. Run the app from this branch
  3. Check that the DNS is still set the the custom one

Feature Flag

  1. Check that no option is visible for risky domains protection under the default DNS
  2. Select the default DNS and visit http://malware.privacy-test-pages.site/ check it loads
  3. Go to debug menu Feature Flags -> turn the Network protection block risky domain flag on
  4. Check that when you visit http://malware.privacy-test-pages.site/ it still loads (the flag should not make the VPN restart)
  5. Go to the VPN settings and check that the risky site protection option is visible and it is on
  6. Restart the VPN and check that http://malware.privacy-test-pages.site/ is blocked

Toggle DNS settings

  1. Try toggle the option on and off and check by visiting the test page that the blocking/non blocking is respected
  2. Toggle between default and custom DNS and check that the previously selected risk protection option is retained
  3. When going back to custom check that the IP address previously selected is retained

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against f2d4261

@SabrinaTardio SabrinaTardio marked this pull request as ready for review February 14, 2025 12:31
@SabrinaTardio SabrinaTardio changed the title Sabrina/risky sites protection risky domains protection Feb 14, 2025
@SabrinaTardio SabrinaTardio requested review from diegoreymendez and removed request for diegoreymendez February 14, 2025 14:07
Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant