Update versions & simplify conditions

duckduckgo · Feb 20, 2025 · 7b95dae · 7b95dae
1 parent 2778daf
commit 7b95dae
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/pfm-pr-merged.yml b/.github/workflows/pfm-pr-merged.yml
@@ -2,16 +2,16 @@ name: Mark Asana task complete on merge
 
 on:
     pull_request:
-        types: [labeled, closed]
+        types: [closed]
 
 jobs:
     add-pr-merged-comment:
-        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM') && (github.event.action == 'closed') && (github.event.pull_request.merged == true)
+        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM') && (github.event.pull_request.merged == true)
         name: Process Pull Request, closing linked Asana task
         runs-on: ubuntu-latest
         steps:
             - name: Add comment in Asana task
-              uses: duckduckgo/native-github-asana-sync@v1.1
+              uses: duckduckgo/native-github-asana-sync@v1.5
               with:
                   asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
                   trigger-phrase: '\*\*Asana Task/Github Issue:\*\*'

diff --git a/.github/workflows/pfm-pr-opened.yml b/.github/workflows/pfm-pr-opened.yml
@@ -2,18 +2,18 @@ name: Asana Integration after pull request submitted
 
 on:
     pull_request:
-        types: [labeled, opened, reopened]
+        types: [opened, reopened]
 
 jobs:
     process-internal-pr:
-        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM') && (github.event.action == 'opened' || github.event.action == 'reopened')
+        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM')
         name: Process internal Pull Request, adding PR link to Asana task if present
         runs-on: ubuntu-latest
         permissions:
             issues: write
         steps:
             - name: Add comment in Asana task
-              uses: duckduckgo/native-github-asana-sync@v1.1
+              uses: duckduckgo/native-github-asana-sync@v1.5
               with:
                   asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
                   trigger-phrase: '\*\*Asana Task/Github Issue:\*\*'

diff --git a/.github/workflows/pfm-pr-review-notifications.yml b/.github/workflows/pfm-pr-review-notifications.yml
@@ -7,8 +7,8 @@ on:
 jobs:
     pr-reviewed:
         name: Add PR reviewed comment to Asana task
-        uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@v1.4.1
-        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM') && (github.event.review == 'submitted')
+        uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@v1.5
+        if: contains(join(github.event.pull_request.labels.*.name, ','), 'SBT-PFM')
         with:
             trigger-phrase: '\*\*Asana Task/Github Issue:\*\*'
         secrets: