Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary element hiding exceptions #1414

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Oct 19, 2023

Some websites attempt to detect ad blockers by checking if an element
with a common class (e.g. class="ad") is hidden. Sometimes those
websites will display a "Please disable your ad blocker" message to
users when they suspect an ad blocker is active. To avoid getting
caught up in that, we added some websites to our element hiding
exception list. That prevented us from hiding any elements for those
websites.

Let's go back through the list and remove which ones we can. Some of
those ad walls were actually fixed by our "surrogate" script
improvements[1][2][3]. Where necessary though, let's use the new
"disable-default" element hiding rule (which works similarly to
$generichide[4]) so that we avoid hiding elements with the usual
selectors. While we're at it, let's also add the relevant element
hiding rules to hide any blank spaces left by blocking tracking
scripts (since they often relate to ads) that still aren't hidden on
those websites.

1 - duckduckgo/tracker-surrogates@ec20dfb
2 - duckduckgo/tracker-surrogates@75f4e54
3 - duckduckgo/tracker-surrogates@acf0c0f
4 - https://blog.adblockplus.org/development-builds/new-filter-options-generichide-and-genericblock

Asana Task/Github Issue: https://app.asana.com/0/0/1205594040522080/f

@kzar kzar requested review from jonathanKingston, dharb and a team as code owners October 19, 2023 13:50
@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1489,80 +1489,8 @@
                     "domain": "duckduckgo.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1236"
                 },
                 {
-                    "domain": "bild.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/589"
-                },
-                {
-                    "domain": "derstandard.at",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1101"
-                },
-                {
-                    "domain": "foxnews.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/965"
-                },
-                {
-                    "domain": "kbb.com",
-                    "reason": "Adblocker wall"
-                },
-                {
-                    "domain": "wiwo.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "metro.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "blick.ch",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thechive.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "bizjournals.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "slate.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailycaller.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailymail.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "eltiempo.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailyherald.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "publico.es",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "rawstory.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thehindu.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
@@ -2025,8 +1953,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -2056,8 +2004,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -2074,8 +2047,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -2175,8 +2157,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": "[data-targeting]",
@@ -2642,8 +2649,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2899,8 +2918,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2908,8 +2940,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -3025,8 +3082,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -3082,8 +3143,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3263,8 +3333,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1192,62 +1192,8 @@
                 {
                     "domain": "duckduckgo.com"
                 },
                 {
-                    "domain": "bild.de"
-                },
-                {
-                    "domain": "derstandard.at"
-                },
-                {
-                    "domain": "foxnews.com"
-                },
-                {
-                    "domain": "kbb.com"
-                },
-                {
-                    "domain": "wiwo.de"
-                },
-                {
-                    "domain": "metro.co.uk"
-                },
-                {
-                    "domain": "blick.ch"
-                },
-                {
-                    "domain": "thechive.com"
-                },
-                {
-                    "domain": "bizjournals.com"
-                },
-                {
-                    "domain": "slate.com"
-                },
-                {
-                    "domain": "dailycaller.com"
-                },
-                {
-                    "domain": "dailymail.co.uk"
-                },
-                {
-                    "domain": "eltiempo.com"
-                },
-                {
-                    "domain": "dailyherald.com"
-                },
-                {
-                    "domain": "publico.es"
-                },
-                {
-                    "domain": "rawstory.com"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de"
-                },
-                {
-                    "domain": "thehindu.com"
-                },
-                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"
@@ -1706,8 +1652,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -1737,8 +1703,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -1755,8 +1746,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -1856,8 +1856,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": "[data-targeting]",
@@ -2323,8 +2348,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2580,8 +2617,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2589,8 +2639,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -2706,8 +2781,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -2763,8 +2842,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -2944,8 +3032,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",

@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1489,80 +1489,8 @@
                     "domain": "duckduckgo.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1236"
                 },
                 {
-                    "domain": "bild.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/589"
-                },
-                {
-                    "domain": "derstandard.at",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1101"
-                },
-                {
-                    "domain": "foxnews.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/965"
-                },
-                {
-                    "domain": "kbb.com",
-                    "reason": "Adblocker wall"
-                },
-                {
-                    "domain": "wiwo.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "metro.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "blick.ch",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thechive.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "bizjournals.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "slate.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailycaller.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailymail.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "eltiempo.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailyherald.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "publico.es",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "rawstory.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thehindu.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
@@ -2025,8 +1953,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -2056,8 +2004,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -2074,8 +2047,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -2175,8 +2157,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": "[data-targeting]",
@@ -2642,8 +2649,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2899,8 +2918,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2908,8 +2940,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -3025,8 +3082,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -3082,8 +3143,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3263,8 +3333,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1192,62 +1192,8 @@
                 {
                     "domain": "duckduckgo.com"
                 },
                 {
-                    "domain": "bild.de"
-                },
-                {
-                    "domain": "derstandard.at"
-                },
-                {
-                    "domain": "foxnews.com"
-                },
-                {
-                    "domain": "kbb.com"
-                },
-                {
-                    "domain": "wiwo.de"
-                },
-                {
-                    "domain": "metro.co.uk"
-                },
-                {
-                    "domain": "blick.ch"
-                },
-                {
-                    "domain": "thechive.com"
-                },
-                {
-                    "domain": "bizjournals.com"
-                },
-                {
-                    "domain": "slate.com"
-                },
-                {
-                    "domain": "dailycaller.com"
-                },
-                {
-                    "domain": "dailymail.co.uk"
-                },
-                {
-                    "domain": "eltiempo.com"
-                },
-                {
-                    "domain": "dailyherald.com"
-                },
-                {
-                    "domain": "publico.es"
-                },
-                {
-                    "domain": "rawstory.com"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de"
-                },
-                {
-                    "domain": "thehindu.com"
-                },
-                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"
@@ -1706,8 +1652,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -1737,8 +1703,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -1755,8 +1746,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -1856,8 +1856,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": "[data-targeting]",
@@ -2323,8 +2348,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2580,8 +2617,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2589,8 +2639,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -2706,8 +2781,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -2763,8 +2842,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -2944,8 +3032,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",

@dharb
Copy link
Collaborator

dharb commented Oct 19, 2023

Thanks @kzar, looks great! But let's wait to merge this until the new surrogates are shipped on all clients so we don't inadvertently retrigger adblock walls on clients that haven't updated yet.

@kzar kzar marked this pull request as draft October 19, 2023 17:36
@kzar kzar force-pushed the ad-wall-elem-hide branch from 360c495 to 782fd33 Compare November 9, 2023 13:32
Copy link

github-actions bot commented Nov 9, 2023

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1501,80 +1501,8 @@
                     "domain": "duckduckgo.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1236"
                 },
                 {
-                    "domain": "bild.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/589"
-                },
-                {
-                    "domain": "derstandard.at",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1101"
-                },
-                {
-                    "domain": "foxnews.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/965"
-                },
-                {
-                    "domain": "kbb.com",
-                    "reason": "Adblocker wall"
-                },
-                {
-                    "domain": "wiwo.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "metro.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "blick.ch",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thechive.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "bizjournals.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "slate.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailycaller.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailymail.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "eltiempo.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailyherald.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "publico.es",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "rawstory.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thehindu.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
@@ -2098,8 +2026,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -2138,8 +2086,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -2156,8 +2129,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -2257,8 +2239,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2768,8 +2775,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -3034,8 +3053,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -3043,8 +3075,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -3169,8 +3226,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -3235,8 +3296,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3434,8 +3504,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1202,62 +1202,8 @@
                 {
                     "domain": "duckduckgo.com"
                 },
                 {
-                    "domain": "bild.de"
-                },
-                {
-                    "domain": "derstandard.at"
-                },
-                {
-                    "domain": "foxnews.com"
-                },
-                {
-                    "domain": "kbb.com"
-                },
-                {
-                    "domain": "wiwo.de"
-                },
-                {
-                    "domain": "metro.co.uk"
-                },
-                {
-                    "domain": "blick.ch"
-                },
-                {
-                    "domain": "thechive.com"
-                },
-                {
-                    "domain": "bizjournals.com"
-                },
-                {
-                    "domain": "slate.com"
-                },
-                {
-                    "domain": "dailycaller.com"
-                },
-                {
-                    "domain": "dailymail.co.uk"
-                },
-                {
-                    "domain": "eltiempo.com"
-                },
-                {
-                    "domain": "dailyherald.com"
-                },
-                {
-                    "domain": "publico.es"
-                },
-                {
-                    "domain": "rawstory.com"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de"
-                },
-                {
-                    "domain": "thehindu.com"
-                },
-                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"
@@ -1777,8 +1723,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -1817,8 +1783,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -1835,8 +1826,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -1936,8 +1936,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2447,8 +2472,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2713,8 +2750,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2722,8 +2772,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -2848,8 +2923,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -2914,8 +2993,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3113,8 +3201,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",

@kzar kzar force-pushed the ad-wall-elem-hide branch from 782fd33 to 0e538c9 Compare November 9, 2023 15:00
Copy link

github-actions bot commented Nov 9, 2023

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1501,80 +1501,8 @@
                     "domain": "duckduckgo.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1236"
                 },
                 {
-                    "domain": "bild.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/589"
-                },
-                {
-                    "domain": "derstandard.at",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1101"
-                },
-                {
-                    "domain": "foxnews.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/965"
-                },
-                {
-                    "domain": "kbb.com",
-                    "reason": "Adblocker wall"
-                },
-                {
-                    "domain": "wiwo.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "metro.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "blick.ch",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thechive.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "bizjournals.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "slate.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailycaller.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailymail.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "eltiempo.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailyherald.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "publico.es",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "rawstory.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thehindu.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
@@ -2098,8 +2026,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -2138,8 +2086,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -2156,8 +2129,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -2257,8 +2239,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2768,8 +2775,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -3034,8 +3053,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -3043,8 +3075,37 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".container_proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -3169,8 +3230,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -3235,8 +3300,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3434,8 +3508,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1202,62 +1202,8 @@
                 {
                     "domain": "duckduckgo.com"
                 },
                 {
-                    "domain": "bild.de"
-                },
-                {
-                    "domain": "derstandard.at"
-                },
-                {
-                    "domain": "foxnews.com"
-                },
-                {
-                    "domain": "kbb.com"
-                },
-                {
-                    "domain": "wiwo.de"
-                },
-                {
-                    "domain": "metro.co.uk"
-                },
-                {
-                    "domain": "blick.ch"
-                },
-                {
-                    "domain": "thechive.com"
-                },
-                {
-                    "domain": "bizjournals.com"
-                },
-                {
-                    "domain": "slate.com"
-                },
-                {
-                    "domain": "dailycaller.com"
-                },
-                {
-                    "domain": "dailymail.co.uk"
-                },
-                {
-                    "domain": "eltiempo.com"
-                },
-                {
-                    "domain": "dailyherald.com"
-                },
-                {
-                    "domain": "publico.es"
-                },
-                {
-                    "domain": "rawstory.com"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de"
-                },
-                {
-                    "domain": "thehindu.com"
-                },
-                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"
@@ -1777,8 +1723,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -1817,8 +1783,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -1835,8 +1826,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -1936,8 +1936,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2447,8 +2472,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2713,8 +2750,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2722,8 +2772,37 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".container_proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -2848,8 +2927,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -2914,8 +2997,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3113,8 +3205,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",

@kzar kzar marked this pull request as ready for review November 9, 2023 15:01
Some websites attempt to detect ad blockers by checking if an element
with a common class (e.g. class="ad") is hidden. Sometimes those
websites will display a "Please disable your ad blocker" message to
users when they suspect an ad blocker is active. To avoid getting
caught up in that, we added some websites to our element hiding
exception list. That prevented us from hiding any elements for those
websites.

Let's go back through the list and remove which ones we can. Some of
those ad walls were actually fixed by our "surrogate" script
improvements[1][2][3]. Where necessary though, let's use the new
"disable-default" element hiding rule (which works similarly to
$generichide[4]) so that we avoid hiding elements with the usual
selectors. While we're at it, let's also add the relevant element
hiding rules to hide any blank spaces left by blocking tracking
scripts (since they often relate to ads) that still aren't hidden on
those websites.

1 - duckduckgo/tracker-surrogates@ec20dfb
2 - duckduckgo/tracker-surrogates@75f4e54
3 - duckduckgo/tracker-surrogates@acf0c0f
4 - https://blog.adblockplus.org/development-builds/new-filter-options-generichide-and-genericblock
@kzar kzar force-pushed the ad-wall-elem-hide branch from 0e538c9 to 293f869 Compare November 9, 2023 16:21
Copy link

github-actions bot commented Nov 9, 2023

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1501,80 +1501,8 @@
                     "domain": "duckduckgo.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1236"
                 },
                 {
-                    "domain": "bild.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/589"
-                },
-                {
-                    "domain": "derstandard.at",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1101"
-                },
-                {
-                    "domain": "foxnews.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/965"
-                },
-                {
-                    "domain": "kbb.com",
-                    "reason": "Adblocker wall"
-                },
-                {
-                    "domain": "wiwo.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "metro.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "blick.ch",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thechive.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "bizjournals.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "slate.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailycaller.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailymail.co.uk",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "eltiempo.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "dailyherald.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "publico.es",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "rawstory.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
-                    "domain": "thehindu.com",
-                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/592"
-                },
-                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
@@ -2098,8 +2026,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -2138,8 +2086,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -2156,8 +2129,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -2257,8 +2239,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2768,8 +2775,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -3034,8 +3053,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -3043,8 +3075,37 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".container_proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -3169,8 +3230,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -3235,8 +3300,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3434,8 +3508,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1202,62 +1202,8 @@
                 {
                     "domain": "duckduckgo.com"
                 },
                 {
-                    "domain": "bild.de"
-                },
-                {
-                    "domain": "derstandard.at"
-                },
-                {
-                    "domain": "foxnews.com"
-                },
-                {
-                    "domain": "kbb.com"
-                },
-                {
-                    "domain": "wiwo.de"
-                },
-                {
-                    "domain": "metro.co.uk"
-                },
-                {
-                    "domain": "blick.ch"
-                },
-                {
-                    "domain": "thechive.com"
-                },
-                {
-                    "domain": "bizjournals.com"
-                },
-                {
-                    "domain": "slate.com"
-                },
-                {
-                    "domain": "dailycaller.com"
-                },
-                {
-                    "domain": "dailymail.co.uk"
-                },
-                {
-                    "domain": "eltiempo.com"
-                },
-                {
-                    "domain": "dailyherald.com"
-                },
-                {
-                    "domain": "publico.es"
-                },
-                {
-                    "domain": "rawstory.com"
-                },
-                {
-                    "domain": "allgemeine-zeitung.de"
-                },
-                {
-                    "domain": "thehindu.com"
-                },
-                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"
@@ -1777,8 +1723,28 @@
                             }
                         ]
                     },
                     {
+                        "domain": "allgemeine-zeitung.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".adSlot",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".adBorder",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".nativeAd",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "apnews.com",
                         "rules": [
                             {
                                 "selector": ".proper-dynamic-insertion",
@@ -1817,8 +1783,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "bild.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[id^='mrec']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#superbanner",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "bizjournals.com",
+                        "rules": [
+                            {
+                                "selector": ".adwrap",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bleacherreport.com",
                         "rules": [
                             {
                                 "selector": ".br-ad-wrapper",
@@ -1835,8 +1826,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "blick.ch",
+                        "rules": [
+                            {
+                                "selector": "[id*='appnexus-placement-']",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "bloomberg.com",
                         "rules": [
                             {
                                 "selector": ".unsupported-browser-notification-container",
@@ -1936,8 +1936,33 @@
                             }
                         ]
                     },
                     {
+                        "domain": "dailyherald.com",
+                        "rules": [
+                            {
+                                "selector": ".instoryAdBlock",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
+                        "domain": "dailymail.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": "[class*='dmg-ads']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".mol-ads-label-container",
+                                "type": "closest-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "dallasnews.com",
                         "rules": [
                             {
                                 "selector": ".adhesiveAdWrapper",
@@ -2447,8 +2472,20 @@
                             }
                         ]
                     },
                     {
+                        "domain": "metro.co.uk",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            },
+                            {
+                                "selector": ".ad-slot-container",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "mirror.co.uk",
                         "rules": [
                             {
                                 "selector": "#comments-standalone-mpu",
@@ -2713,8 +2750,21 @@
                             }
                         ]
                     },
                     {
+                        "domain": "publico.es",
+                        "rules": [
+                            {
+                                "selector": ".pb-ads",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#sc_intxt_container",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "qz.com",
                         "rules": [
                             {
                                 "selector": "#marquee-ad",
@@ -2722,8 +2772,37 @@
                             }
                         ]
                     },
                     {
+                        "domain": "rawstory.com",
+                        "rules": [
+                            {
+                                "selector": ".container_proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".controlled_via_ad_manager",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": ".mgid_3x2",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".proper-ad-unit",
+                                "type": "hide"
+                            },
+                            {
+                                "selector": "[id^='rc-widget-']",
+                                "type": "hide-empty"
+                            },
+                            {
+                                "selector": "#story-top-ad",
+                                "type": "hide"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "reddit.com",
                         "rules": [
                             {
                                 "selector": "._233XfOVq91N_ugGQDBb_OT",
@@ -2848,8 +2927,12 @@
                         "rules": [
                             {
                                 "selector": ".slate-ad",
                                 "type": "hide-empty"
+                            },
+                            {
+                                "selector": ".top-ad",
+                                "type": "hide"
                             }
                         ]
                     },
                     {
@@ -2914,8 +2997,17 @@
                             }
                         ]
                     },
                     {
+                        "domain": "thehindu.com",
+                        "rules": [
+                            {
+                                "selector": "#articledivrec",
+                                "type": "hide-empty"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "thetimes.co.uk",
                         "rules": [
                             {
                                 "selector": "#ad-header",
@@ -3113,8 +3205,16 @@
                             }
                         ]
                     },
                     {
+                        "domain": "wiwo.de",
+                        "rules": [
+                            {
+                                "type": "disable-default"
+                            }
+                        ]
+                    },
+                    {
                         "domain": "wsj.com",
                         "rules": [
                             {
                                 "selector": "#cx-what-to-read-next",

Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dharb dharb merged commit bc4e0d3 into main Nov 9, 2023
3 checks passed
@dharb dharb deleted the ad-wall-elem-hide branch November 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants