Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove renamed floc feature #2405

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Remove renamed floc feature #2405

merged 2 commits into from
Dec 20, 2024

Conversation

jonathanKingston
Copy link
Collaborator

Asana Task/Github Issue:

Description

Remove feature that since was long ago renamed to googleRejected

Reference

@jonathanKingston jonathanKingston requested review from kzar and a team as code owners October 29, 2024 12:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Generated file outputs:

Time updated: Fri, 20 Dec 2024 09:45:24 GMT

legacy
trackers-unprotected-temporary.txt (14 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

@jonathanKingston jonathanKingston marked this pull request as draft November 8, 2024 11:14
auto-merge was automatically disabled November 8, 2024 11:14

Pull request was converted to draft

kdzwinel
kdzwinel previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we stoped using it over 2y ago (https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/1037/files) so I'm on board with that 👍

@jonathanKingston
Remove renamed floc feature
9a1baf6 
Remove feature that since was long ago renamed to googleRejected
@jonathanKingston
Remove feature file
e250433
@jonathanKingston jonathanKingston marked this pull request as ready for review December 20, 2024 09:45
kdzwinel
kdzwinel approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STILL looks good :)

@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 12bba48 Dec 20, 2024
10 checks passed
@jonathanKingston jonathanKingston deleted the jkt/removeFloc branch December 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdzwinel kdzwinel kdzwinel approved these changes

@kzar kzar Awaiting requested review from kzar kzar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @kdzwinel