Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FireWindow enabled in version 0.98 #2585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibebbs
Copy link
Contributor

@ibebbs ibebbs commented Dec 16, 2024

Asana Task/Github Issue: https://app.asana.com/0/1208228079594252/1208935076401374/f

Description

  • Enables FireWindow feature and sets minimum supported version of 0.98

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Reference

Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Mon, 16 Dec 2024 12:22:18 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json

⚠️ File is identical

v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -10942,9 +10942,10 @@
             "minSupportedVersion": "0.91.0"
         },
         "windowsFireWindow": {
             "exceptions": [],
-            "state": "disabled"
+            "state": "enabled",
+            "minSupportedVersion": "0.98.0"
         },
         "windowsNewTabPageExperiment": {
             "state": "enabled",
             "exceptions": [],
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -9895,9 +9895,10 @@
             "minSupportedVersion": "0.91.0"
         },
         "windowsFireWindow": {
             "exceptions": [],
-            "state": "disabled"
+            "state": "enabled",
+            "minSupportedVersion": "0.98.0"
         },
         "windowsNewTabPageExperiment": {
             "state": "enabled",
             "exceptions": [],

@ibebbs ibebbs marked this pull request as ready for review December 16, 2024 12:28
@ibebbs ibebbs requested review from a team as code owners December 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant