Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CPM on collectcheckout.com #2589

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Disable CPM on collectcheckout.com #2589

merged 1 commit into from
Dec 16, 2024

Conversation

sammacbeth
Copy link
Collaborator

Asana Task/Github Issue: https://app.asana.com/0/1206670747178362/1208989992600639/f

Description

Pre-hide selectors are hiding CC input field.

Pre-hide selectors are hiding CC input field.
@sammacbeth sammacbeth requested review from muodov and a team as code owners December 16, 2024 16:23
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Mon, 16 Dec 2024 16:23:31 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1059,8 +1059,12 @@
                     "domain": "wetransfer.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2580"
                 },
                 {
+                    "domain": "collectcheckout.com",
+                    "reason": "Pre-hide selectors hide CC input option"
+                },
+                {
                     "domain": "marvel.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
                 },
                 {
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -838,8 +838,11 @@
                 {
                     "domain": "wetransfer.com"
                 },
                 {
+                    "domain": "collectcheckout.com"
+                },
+                {
                     "domain": "marvel.com"
                 },
                 {
                     "domain": "sundancecatalog.com"

Copy link
Contributor

@laghee laghee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laghee laghee added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@sammacbeth sammacbeth added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 20d46c5 Dec 16, 2024
12 checks passed
@sammacbeth sammacbeth deleted the sammacbeth-patch-1 branch December 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants