Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable setAccessTokenCookieForSubscriptionDomains #2596

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Dec 17, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1208995433613801/f

Description

This PR disables setAccessTokenCookieForSubscriptionDomains for iOS and macOS.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@samsymons samsymons requested a review from miasma13 December 17, 2024 20:35
@samsymons samsymons requested review from a team as code owners December 17, 2024 20:35
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Tue, 17 Dec 2024 20:36:16 GMT

legacy
trackers-unprotected-temporary.txt (12 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/ios-config.json (1 more)
  • v3/ios-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -7034,9 +7034,9 @@
                     "state": "enabled",
                     "minSupportedVersion": "1.113.0"
                 },
                 "setAccessTokenCookieForSubscriptionDomains": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "rollout": {
                         "steps": [
                             {
                                 "percent": 25
latest
v4/android-config.json (11 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/ios-config.json (1 more)
  • v4/ios-config.json
  • v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6385,9 +6385,9 @@
                     "state": "enabled",
                     "minSupportedVersion": "1.113.0"
                 },
                 "setAccessTokenCookieForSubscriptionDomains": {
-                    "state": "enabled",
+                    "state": "disabled",
                     "rollout": {
                         "steps": [
                             {
                                 "percent": 25

@samsymons samsymons added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit aa35178 Dec 17, 2024
15 checks passed
@samsymons samsymons deleted the sam/disable-subscription-status-feature-flags branch December 17, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants