Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable import promo in autofill for Windows #2598

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

gkerenyi
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/1203709236521659/1209004797220300/f

Description

Temporarily disables password import promotion on Windows for all users, because the button doesn't work since the v0.96 version. The feature flags will be re-enabled after rolling out the fix to the majority of users.

Reference

@gkerenyi gkerenyi requested review from a team as code owners December 18, 2024 13:35
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Wed, 18 Dec 2024 13:35:54 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json

⚠️ File is identical

v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -877,12 +877,12 @@
                 "unknownUsernameCategorization": {
                     "state": "enabled"
                 },
                 "credentialsImportPromotion": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "credentialsImportPromotionForExistingUsers": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "partialFormSaves": {
                     "state": "disabled"
                 }
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -711,12 +711,12 @@
                 "unknownUsernameCategorization": {
                     "state": "enabled"
                 },
                 "credentialsImportPromotion": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "credentialsImportPromotionForExistingUsers": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "partialFormSaves": {
                     "state": "disabled"
                 }

@gkerenyi gkerenyi enabled auto-merge December 18, 2024 13:36
@gkerenyi gkerenyi added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 434c810 Dec 18, 2024
12 checks passed
@gkerenyi gkerenyi deleted the gabor/autofill_disable_import_promo_windows branch December 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants