Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Config: Update "featuresRequestHeader" configuration for versions 5.222.0 and 5.223.0 #2602

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Dec 19, 2024

Asana Task/Github Issue: https://app.asana.com/0/0/1209015004618387/f

Description

Updated featuresRequestHeader. Renamed appTp to appTP. Added configurations for versions 52220000 and 52230000.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@anikiki anikiki requested review from a team as code owners December 19, 2024 18:32
Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Dec 19, 2024

Generated file outputs:

Time updated: Thu, 19 Dec 2024 20:01:29 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -199,11 +199,33 @@
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": true,
                                     "cpm": true,
-                                    "appTp": false,
+                                    "appTP": false,
                                     "netP": false
                                 }
+                            },
+                            {
+                                "appVersion": 52220000,
+                                "daysAfterBuild": 6,
+                                "daysLogging": 28,
+                                "featuresLogged": {
+                                    "gpc": false,
+                                    "cpm": false,
+                                    "appTP": true,
+                                    "netP": false
+                                }
+                            },
+                            {
+                                "appVersion": 52230000,
+                                "daysAfterBuild": 6,
+                                "daysLogging": 10,
+                                "featuresLogged": {
+                                    "gpc": false,
+                                    "cpm": true,
+                                    "appTP": false,
+                                    "netP": false
+                                }
                             }
                         ]
                     }
                 }
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -190,11 +190,33 @@
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": true,
                                     "cpm": true,
-                                    "appTp": false,
+                                    "appTP": false,
                                     "netP": false
                                 }
+                            },
+                            {
+                                "appVersion": 52220000,
+                                "daysAfterBuild": 6,
+                                "daysLogging": 28,
+                                "featuresLogged": {
+                                    "gpc": false,
+                                    "cpm": false,
+                                    "appTP": true,
+                                    "netP": false
+                                }
+                            },
+                            {
+                                "appVersion": 52230000,
+                                "daysAfterBuild": 6,
+                                "daysLogging": 10,
+                                "featuresLogged": {
+                                    "gpc": false,
+                                    "cpm": true,
+                                    "appTP": false,
+                                    "netP": false
+                                }
                             }
                         ]
                     }
                 }
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

malmstein
malmstein previously approved these changes Dec 19, 2024
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one change on the logging days for 5.222.0

overrides/android-override.json Show resolved Hide resolved
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@anikiki anikiki added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit f3ba941 Dec 20, 2024
10 checks passed
@anikiki anikiki deleted the feature/ana/privacy_config_update_featuresrequestheader_configuration_for_versions_52220_and_52230 branch December 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants