Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature settings #119

Merged
merged 13 commits into from
Oct 12, 2023
Merged

Added feature settings #119

merged 13 commits into from
Oct 12, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Oct 5, 2023 •
edited
Loading

Reviewer: @sammacbeth

Description:

We're adding an alternative layout for the primary screen that native platforms can opt-in to.

  • added new method, onChangeFeatureSettings
  • added new interface in the schema, RemoteFeatureSettings
    • initially it just contains primaryScreen.layout which can be either default or highlighted-protections-toggle
  • Android PR: Support alternative Dashboard layout Android#3615

Steps to test this PR:

@shakyShane
Copy link
Collaborator Author

shakyShane commented Oct 5, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@shakyShane shakyShane changed the base branch from main to shane/simply_mocks October 5, 2023 17:54
@shakyShane shakyShane mentioned this pull request Oct 5, 2023
Merged
@shakyShane shakyShane changed the title simplify mocks Added feature settings Oct 5, 2023
@shakyShane
Copy link
Collaborator Author

image image

@shakyShane shakyShane requested a review from sammacbeth October 5, 2023 17:58
@shakyShane shakyShane changed the base branch from shane/simply_mocks to main October 5, 2023 18:04
@shakyShane shakyShane force-pushed the shane/feature_settings branch from 3fbe02e to abfab03 Compare October 6, 2023 14:05
@shakyShane shakyShane force-pushed the shane/feature_settings branch from abfab03 to e65f4af Compare October 6, 2023 14:06
alistairjcbrown
alistairjcbrown reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@alistairjcbrown alistairjcbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick skim through -- some non-blocking comments, but from a brief look it LGTM

integration-tests/android.spec-int.js Show resolved Hide resolved
shared/js/ui/components/toggle.jsx Show resolved Hide resolved
shared/js/ui/templates/key-insights.js Outdated Show resolved Hide resolved
@shakyShane shakyShane merged commit 26cf7d3 into main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistairjcbrown alistairjcbrown alistairjcbrown left review comments

@sammacbeth sammacbeth sammacbeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shakyShane @sammacbeth @alistairjcbrown