Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update tests for boolean parameters #118

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion broken-site-reporting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ Test suite specific fields:
- `remoteConfigVersion` - string - string representation of remote configuration version (note, this is the numeric version found in the remote config (e.g, `1680178584671`, not `v1` or `v2`))
- `providedDescription` - string - user-provided breakage description
- `protectionsEnabled` - boolean - if protections are enabled (true) or disabled (false) as visible to the user on the dashboard.
- `consentManaged` - bool - if the browser handled a cookie pop-up on the site
- `consentOptoutFailed` - bool - if the opt-out process returned failed
- `consentSelftestFailed` - bool - if the rule's self-test failed
- `urlParametersRemoved` - bool - if URL parameters were removed

All of these custom fields are supported by the `reports` array objects within the multiple_report_tests.json file.

Expand Down Expand Up @@ -139,4 +143,4 @@ the reference tests is provided below:
- see https://app.asana.com/0/0/1204271046995906/f for more information about truncation and implementation requirements
- param `protectionsState`
- The Extension is the only platform that supports a 'denylist' - this allows a user to override remote configurations and forcibly enable protections even when we've tried to disable them.
- For this case, an extension-only case was added in `broken-site-reporting/tests.json`
- For this case, an extension-only case was added in `broken-site-reporting/tests.json`
31 changes: 28 additions & 3 deletions broken-site-reporting/tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@
{"name": "tds", "value": "abc123"},
{"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"},
{"name": "surrogates", "value": "surrogate.domain.test,domain2.com,nested.sub.domain3.com"},
{"name": "truncated", "value": "1"},
{"name": "truncated", "value": "true"},
{"name": "protectionsState", "value": "true"}
],
"exceptPlatforms": [
Expand Down Expand Up @@ -378,7 +378,7 @@
{"name": "tds", "value": "abc123"},
{"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"},
{"name": "surrogates", "value": "surrogate.domain.test,domain2.com,nested.sub.domain3.com"},
{"name": "truncated", "value": "1"},
{"name": "truncated", "value": "true"},
{"name": "protectionsState", "value": "true"}
],
"exceptPlatforms": [
Expand Down Expand Up @@ -411,7 +411,7 @@
{"name": "tds", "value": "abc123"},
{"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"},
{"name": "surrogates", "value": "surrogate.domain.test,domain2.com,nested.sub.domain3.com"},
{"name": "truncated", "value": "1"},
{"name": "truncated", "value": "true"},
{"name": "protectionsState", "value": "true"}
],
"exceptPlatforms": [
Expand All @@ -421,6 +421,31 @@
"safari-extension",
"windows-browser"
]
},
{
"name": "Default sending of consent* parameters",
"siteURL": "http://example.com/",
"expectReportURLParams": [
{"name": "consentManaged", "value": "false"},
{"name": "consentOptoutFailed", "value": "false"},
{"name": "consentSelftestFailed", "value": "false"}
],
"exceptPlatforms": [
"ios-browser",
"safari-extension",
"web-extension"
]
},
{
"name": "Default sending of urlParametersRemoved",
"siteURL": "http://example.com/",
"expectReportURLParams": [
{"name": "urlParametersRemoved", "value": "false"}
],
"exceptPlatforms": [
"safari-extension",
"windows-browser"
]
}
]
}
Expand Down
Loading