Validate 'isFirstParty' logic for tracker that only has eTLD+2 domain defined #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 domain (e.g. bad.etld-plus-two.site), tracker requests are correctly Ignored
kdzwinel
approved these changes
Sep 26, 2024
| @@ -1077,7 +1084,7 @@ | |||
| "expectAction": "redirect", | |||
| "expectRedirect": "data:application/javascript;base64,KGZ1bmN0aW9uKCkge3dpbmRvdy5zdXJyb2dhdGUxPXRydWV9KSgpOw==", | |||
| "expectExpression": "window.surrogate1 === true" | |||
| } | |||
| } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bad.third-party.sitehad some sub-requests blocked due to 1st-vs-3rd party logic looking up eTLD+1 for tracker entity lookup (which isthird-party.site- so in this case, did not find thebad.third-party.siteEntity). This has now been fixed and is instead using the Tracker's Entity name to look up the Entity.See https://app.asana.com/0/1199608453935138/1208394000709735/f for more detail.