Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create pull_request_template.md #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3385022
Create pull_request_template.md
ladamski Aug 17, 2022
f18b910
update draft, reviewer copy
Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!-- Please create the PR as a draft if is not ready for final review and merge -->

**Reviewer:** <!-- ideally the feature DRI, otherwise reference tests DRI or secondary as fallbacks -->

<!-- Optional fields
**CC:**
**Depends on:**
-->

## Description:

Project task:

Relevant products which you have tested these changes against (i.e. extension, Windows, ...):
-

Product PRs to test against:
-

**Note: Upon merging this PR, you are responsible for updating the affected products to the latest version of this repo.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that this will make sure that people don't contribute edge-cases etc. IMO all products should automatically pull and run changes and if test is correct (and this is up to person creating PR and feature DRI and/or us) then failing test on some platform is like a bug report for them to align.


## Steps to test this PR:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that applies? The only step is "run tests see if they pass". The bigger concern is if test is correctly describing the edge-case that we are trying to capture.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that really goes to the role of the author.. is it just the write the test and sort of mic-drop, or ensure the test is valid on the major products (and note platform exceptions where its not)? Sometimes there are subtle implementation difference that aren't clear before you try them (i.e. on one platform you might get an "ignore", another might be null).

My concern is to avoid a scenario where the tests are just frequently broken on some products, to the degree that it becomes a disincentive to keep updating them. If we roll out automation maybe that becomes less of a concern? Not sure TBH.

Perhaps at least ensure they are passing on the extension?

<!-- List steps to test it manually
1. <STEP 1>
-->

###### PR Author Checklist:
- [ ] PRs exists for affected products to bump up to latest commit (in this PR)
- [ ] Ensure privacy reference tests in the above PRs pass