Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viewport test pages #177

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add viewport test pages #177

merged 4 commits into from
Dec 20, 2023

Conversation

muodov
Copy link
Member

@muodov muodov commented Nov 30, 2023

Asana Task/Github Issue: https://app.asana.com/0/0/1206035072570211/f

Description

A bunch of pages to test various use-cases of the viewport meta tag

Reference

@muodov muodov requested a review from kdzwinel November 30, 2023 13:06
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max! I left some high-level questions

index.html Outdated Show resolved Hide resolved
webcompat/viewport/index.html Outdated Show resolved Hide resolved
@muodov muodov requested a review from kdzwinel December 4, 2023 14:04
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for creating that BE component! I left one more small comment, but feel free to merge after that.

viewport/server/viewport-template.html Show resolved Hide resolved
@muodov muodov merged commit 189e0bc into main Dec 20, 2023
1 check passed
@muodov muodov deleted the viewport-tests branch December 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants