Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing popup behavior and security and privacy issues #197

Merged
merged 6 commits into from
May 10, 2024

Conversation

mikamikem
Copy link
Collaborator

@mikamikem mikamikem commented Apr 12, 2024

Test pages to validate noopener and noreferrer are being respected. Prompted by https://app.asana.com/0/1199892415909552/1207023955301654/f

These need to be hosted to satisfy CORS requirements, file:// URI's are treated as separate domains even if they share the same base path, so browsers will throw permission errors if window.opener is requested from the popup.

  • noopener window.open() check
  • target="_blank" check
  • noreferrer window.open() check
  • rel="noopener" check
  • rel="noreferrer" check

@mikamikem mikamikem marked this pull request as ready for review April 25, 2024 23:37
@mikamikem mikamikem requested a review from kdzwinel April 25, 2024 23:37
Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nora! Thanks for crating those pages 🙏 I left you some small comments re the format of pages / categorization - hopefully no more than 10min of work.

index.html Outdated Show resolved Hide resolved
features/popups/popup-launcher.html Outdated Show resolved Hide resolved
@not-a-rootkit not-a-rootkit merged commit 59e5013 into main May 10, 2024
1 check passed
@not-a-rootkit not-a-rootkit deleted the nora/popups branch May 10, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants