Exempt Safari and WebKit-based DDG browsers from using serverTiming #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1186013049913869/1205272059194928/f
Looks like Safari added serverTiming support last year, which led to two code paths checking for the success of the load running. From what I can tell, they don't support it for cross-origin loads though, so one code path will always return
blocked. This was leading to a race condition between the two measurement methods and inconsistent output.I also renamed the two
fireResourcemethods within the injected scripts, since I saw some timing inconsistency there as well from the naming conflict.