Add URL canonicalization tests. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Malicious URL detection relies on URL canonicalization to prevent bypasses - this implements test cases to ensure our canonicalization works, when combined with our in-browser URL parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task: https://app.asana.com/0/0/1207138193507367/f
Our browsers are soon to be implementing URL canonicalization and we need a series of tests to ensure this is working as expected. Here we introduce several test cases based on the algorithm defined in the above Asana tasks. The aim is that each of these should be clicked, and the page should never load. If it loads, it indicates that our URL canonicalization is broken.
Note: this cannot be tested yet, soon a macOS PR will test against this.