Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected pixels to ad click attribution test cases #219

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add expected pixels to ad click attribution test cases #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 170 additions & 14 deletions adClickFlow/shared/testCases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"url": "https://www.search-company.site/#ad-id-1"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-1"
"url": "https://www.search-company.site/#ad-id-1",
"pixels": []
}
},
{
Expand Down Expand Up @@ -37,7 +38,8 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
]
],
"pixels": []
}
}
]
Expand All @@ -52,7 +54,8 @@
"url": "https://www.search-company.site/#ad-id-2"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-2"
"url": "https://www.search-company.site/#ad-id-2",
"pixels": []
}
},
{
Expand Down Expand Up @@ -81,7 +84,8 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
]
],
"pixels": []
}
}
]
Expand All @@ -96,7 +100,8 @@
"url": "https://www.search-company.site/#ad-id-3"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-3"
"url": "https://www.search-company.site/#ad-id-3",
"pixels": []
}
},
{
Expand Down Expand Up @@ -124,7 +129,8 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
]
],
"pixels": []
}
}
]
Expand All @@ -139,7 +145,8 @@
"url": "https://www.search-company.site/#ad-id-4"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-4"
"url": "https://www.search-company.site/#ad-id-4",
"pixels": []
}
},
{
Expand Down Expand Up @@ -168,7 +175,8 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
]
],
"pixels": []
}
}
]
Expand All @@ -183,7 +191,8 @@
"url": "https://www.search-company.site/#ad-id-5"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-5"
"url": "https://www.search-company.site/#ad-id-5",
"pixels": []
}
},
{
Expand Down Expand Up @@ -211,6 +220,29 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "heuristic_only",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
},
{
"name": "m_pageloads_with_ad_attribution",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an assumption here that for the test runner that we force this to fire at the end of each test case. I think that's okay, but just checking that it's expected.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's right. I would have mentioned that in a comment (like I did in the other version of this file) but unfortunately JSON doesn't support comments.

"params": {
"count": "1"
}
}
]
}
}
Expand All @@ -226,7 +258,8 @@
"url": "https://www.search-company.site/#ad-id-6"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-6"
"url": "https://www.search-company.site/#ad-id-6",
"pixels": []
}
},
{
Expand Down Expand Up @@ -255,6 +288,29 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "heuristic_only",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
},
{
"name": "m_pageloads_with_ad_attribution",
"params": {
"count": "1"
}
}
]
}
}
Expand All @@ -270,7 +326,8 @@
"url": "https://www.search-company.site/#ad-id-7"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-7"
"url": "https://www.search-company.site/#ad-id-7",
"pixels": []
}
},
{
Expand Down Expand Up @@ -298,6 +355,29 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "matched",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
},
{
"name": "m_pageloads_with_ad_attribution",
"params": {
"count": "1"
}
}
]
}
}
Expand All @@ -313,7 +393,8 @@
"url": "https://www.search-company.site/#ad-id-8"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-8"
"url": "https://www.search-company.site/#ad-id-8",
"pixels": []
}
},
{
Expand Down Expand Up @@ -342,6 +423,29 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "matched",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
},
{
"name": "m_pageloads_with_ad_attribution",
"params": {
"count": "1"
}
}
]
}
}
Expand All @@ -357,7 +461,8 @@
"url": "https://www.search-company.site/#ad-id-5"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-5"
"url": "https://www.search-company.site/#ad-id-5",
"pixels": []
}
},
{
Expand Down Expand Up @@ -386,6 +491,23 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "heuristic_only",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
}
]
}
},
Expand Down Expand Up @@ -414,6 +536,14 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_pageloads_with_ad_attribution",
"params": {
"count": "2"
}
}
]
}
}
Expand All @@ -429,7 +559,8 @@
"url": "https://www.search-company.site/#ad-id-5"
},
"expected": {
"url": "https://www.search-company.site/#ad-id-5"
"url": "https://www.search-company.site/#ad-id-5",
"pixels": []
}
},
{
Expand Down Expand Up @@ -457,6 +588,23 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_ad_click_detected",
"params": {
"appVersion": "APP_VERSION",
"domainDetection": "heuristic_only",
"heuristicDetectionEnabled": "1",
"domainDetectionEnabled": "1"
}
},
{
"name": "m_ad_click_active",
"params": {
"appVersion": "APP_VERSION"
}
}
]
}
},
Expand Down Expand Up @@ -486,6 +634,14 @@
"url": "https://www.ad-company.site/ping.gif",
"status": "parent blocked"
}
],
"pixels": [
{
"name": "m_pageloads_with_ad_attribution",
"params": {
"count": "2"
}
}
]
}
}
Expand Down
Loading