Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLOB file download #233

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add BLOB file download #233

merged 2 commits into from
Sep 25, 2024

Conversation

miasma13
Copy link
Contributor

No description provided.

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one nit, feel free to merge after.


<script>
var blob = new Blob(["Hello world!"], {type: "application/octet-stream"});
var link = document.getElementById("blobDownloadLink");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change those vars to consts and your can put "expert JavaScript" on your CV ;)

@miasma13 miasma13 merged commit b474040 into main Sep 25, 2024
1 check passed
@miasma13 miasma13 deleted the michal/add-blob-downloads branch September 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants