Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmful APIs test page #78

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Harmful APIs test page #78

merged 7 commits into from
Feb 8, 2023

Conversation

kdzwinel
Copy link
Member

This page will test if web APIs that are considered harmful are available in your browser. Only availablity is verified, privacy concerns might have been mitigated.

@kdzwinel kdzwinel requested review from englehardt and removed request for jonathanKingston March 25, 2022 17:42
Copy link
Collaborator

@englehardt englehardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things need fixing, but overall this is in good shape. I was worried that a Secure context or the Permissions API may be required for some of these, but that doesn't seem to be the case for the properties I tested.

}
},
{
id: 'client-hints-api',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this test locally using python -m SimpleHTTPServer 8000 I receive an unhelpful error for this test: client-hints-api - ❌ error thrown ("JSON.parse: unexpected character at line 1 column 1 of the JSON data"). This happens because the reflect headers endpoint isn't available (running the node server fixes it).

I wonder if there's an easy way to warn the user using a test page that the text page requires the node server? We could set up a simple endpoint in the node server, ping it, and display an error in the body of the page if it isn't available. Alternatively we can just update the README to say the node server is always required when testing locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea but it'd be nice to do this for all pages affected somehow. I'm putting it on a backlog for now.

features/harmful-apis/main.js Outdated Show resolved Hide resolved
features/harmful-apis/main.js Outdated Show resolved Hide resolved
features/harmful-apis/main.js Outdated Show resolved Hide resolved
features/harmful-apis/main.js Outdated Show resolved Hide resolved
features/harmful-apis/main.js Show resolved Hide resolved
features/harmful-apis/main.js Show resolved Hide resolved
@kdzwinel
Copy link
Member Author

kdzwinel commented May 19, 2022

Note to self: add fledge -> https://developer.chrome.com/docs/privacy-sandbox/fledge/

[edit] - added

@kdzwinel kdzwinel force-pushed the konrad/harmful-apis branch from bc618b2 to 77e491f Compare November 5, 2022 11:56
@kdzwinel
Copy link
Member Author

kdzwinel commented Nov 5, 2022

Thanks for a review @englehardt ! All feedback should be addressed now, back to you.

harmful-apis

Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with this a bit locally, everything looks to be in order. I'm going to go ahead and merge this now so that I can use it in my Windows privacy audit.

@dharb dharb merged commit b3895fb into main Feb 8, 2023
@dharb dharb deleted the konrad/harmful-apis branch February 8, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants