-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmful APIs test page #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things need fixing, but overall this is in good shape. I was worried that a Secure context or the Permissions API may be required for some of these, but that doesn't seem to be the case for the properties I tested.
} | ||
}, | ||
{ | ||
id: 'client-hints-api', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running this test locally using python -m SimpleHTTPServer 8000
I receive an unhelpful error for this test: client-hints-api - ❌ error thrown ("JSON.parse: unexpected character at line 1 column 1 of the JSON data")
. This happens because the reflect headers endpoint isn't available (running the node server fixes it).
I wonder if there's an easy way to warn the user using a test page that the text page requires the node server? We could set up a simple endpoint in the node server, ping it, and display an error in the body of the page if it isn't available. Alternatively we can just update the README to say the node server is always required when testing locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea but it'd be nice to do this for all pages affected somehow. I'm putting it on a backlog for now.
Note to self: add fledge -> https://developer.chrome.com/docs/privacy-sandbox/fledge/ [edit] - added |
bc618b2
to
77e491f
Compare
…clipboard access api, fix lightsensor test
Thanks for a review @englehardt ! All feedback should be addressed now, back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around with this a bit locally, everything looks to be in order. I'm going to go ahead and merge this now so that I can use it in my Windows privacy audit.
This page will test if web APIs that are considered harmful are available in your browser. Only availablity is verified, privacy concerns might have been mitigated.