Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarterly satisfaction survey (and pausing other active surveys) #104

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

amddg44
Copy link
Collaborator

@amddg44 amddg44 commented Sep 16, 2024

Asana: https://app.asana.com/0/0/1208267825401257/f

Description : Adding quarterly satisfactory survey and temporarily removing ios_privacy_pro_subscriber_survey_1

Steps to test:

  • confirm the version number has been incremented
  • confirm the only other active survey remaining is ios_privacy_pro_exit_survey_1 and that the rules it references are still in place
  • confirm new message matches requirements from the description of this task https://app.asana.com/0/1207619243206445/1208265082488130/f
  • Note that the targetPercentile is currently set to 1 as the staging config is being used by the Ship Review build, I’ll be updating it to 0.25 before this goes live
  • To test update the debug URL in RemoteMessagingClient.swift to https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json and confirm the RMF message appears (assuming you meet the rule requirements 🙂).
  • Click the survey link and confirm the correct parameters are appended var;delta;osv;ddgv

Copy link

@amddg44 amddg44 changed the title Add quarterly satisfaction survey Add quarterly satisfaction survey (and pausing other active surveys) Sep 18, 2024
@amddg44 amddg44 marked this pull request as ready for review September 18, 2024 19:13
@amddg44 amddg44 requested a review from a team as a code owner September 18, 2024 19:13
@amddg44 amddg44 requested review from jotaemepereira and aataraxiaa and removed request for a team September 18, 2024 19:13
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @amddg44. One thing - When testing I didn’t see delta in the parameters. Xcode console shows:

https://selfserve.decipherinc.com/survey/selfserve/32ab/240903?list=2&var=ma&osv=18&ddgv=7.13

@aataraxiaa
Copy link
Contributor

Retested and could not reproduce the issue mentioned, perhaps a timing issue as you suggest @amddg44. Xcode console displayed:

https://selfserve.decipherinc.com/survey/selfserve/32ab/240903?list=2&var=ma&delta=0&osv=18&ddgv=7.138.0.3

LGTM.

@amddg44 amddg44 merged commit a752315 into main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants