Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanent iOS survey #108

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Add permanent iOS survey #108

merged 3 commits into from
Oct 11, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Oct 10, 2024

Task: https://app.asana.com/0/1207619243206445/1208454188907378/f

This PR adds the permanent iOS survey. This PR is very similar to previous surveys such as #95, except this survey adds a targetPercentile of 0.3.

Testing instructions:

Note: This survey has a 30% chance of appearing. If it doesn't appear, you could delete and reinstall the app to get a new percentile roll, or you may hardcode RemoteMessagingPercentileUserDefaultsStore to give you a valid value.

  1. Update RemoteMessageRequest to include the sample URL attached in the comments below
  2. Update shouldProcessConfig to always return true
  3. Now we need to test that the install date range is working. We have no method in the Debug menu for overriding this so for now you'll need to use a local copy of BSK and search for the line case let matchingAttribute as DaysSinceInstalledMatchingAttribute
  4. Underneath the line mentioned above, you can override daysSinceInstall value to check the range. Try it with 0, 5, and 10, and check that the message only appears for the 5 case
  5. Finally, set the value back to one that matches the range, and check that opening the link correctly opens the survey

Copy link

@samsymons samsymons marked this pull request as ready for review October 10, 2024 14:06
@samsymons samsymons requested a review from a team as a code owner October 10, 2024 14:06
@samsymons samsymons requested review from quanganhdo and removed request for a team October 10, 2024 14:06
Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to take another pass if you’d like if the parameters change, but all the logic worked as expected & the survey URL built correctly 🙂

* main:
  Update macOS Permanent survey last day to 14 (#107)
@samsymons samsymons merged commit 0fac882 into main Oct 11, 2024
1 check passed
@samsymons samsymons deleted the sam/ios-permanent-survey branch October 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants