Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic update failed message #109

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add automatic update failed message #109

merged 1 commit into from
Oct 16, 2024

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Oct 14, 2024

https://app.asana.com/0/1207619243206445/1208340098560916/f

This PR adds message for users who are stuck on specific versions due to the automatic updates not working properly.

How to test:

  1. Update RemoteMessagingClient.swift's debug URL to use the staging url: https://staticcdn.duckduckgo.com/remotemessaging/config/staging/macos-config.json
  2. Set the app version to 1.99.0
  3. Open a new tab and the message explaining the switching to the manual updates should appear
  4. Set the app version to 1.103.0
  5. Verify the message won't show

@@ -1,5 +1,5 @@
{
"version": 4,
"version": 5,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is necessary to increment in the PR as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, but without it will take clients 24+ hours to check for new messages so it’s best practice 🙂

Copy link

"min": "1.99.0",
"max": "1.102.0"
},
"installedMacAppStore": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have problems with updates for DMG users

@tomasstrba tomasstrba requested a review from amddg44 October 14, 2024 14:16
Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomasstrba LGTM, very nice work!! 👏

@tomasstrba tomasstrba merged commit 9e8690a into main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants