-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic update failed message #109
Conversation
@@ -1,5 +1,5 @@ | |||
{ | |||
"version": 4, | |||
"version": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is necessary to increment in the PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary, but without it will take clients 24+ hours to check for new messages so it’s best practice 🙂
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/macos-config.json |
"min": "1.99.0", | ||
"max": "1.102.0" | ||
}, | ||
"installedMacAppStore": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only have problems with updates for DMG users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomasstrba LGTM, very nice work!! 👏
https://app.asana.com/0/1207619243206445/1208340098560916/f
This PR adds message for users who are stuck on specific versions due to the automatic updates not working properly.
How to test: