Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS Privacy Pro exit survey #114

Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Oct 29, 2024

Task: https://app.asana.com/0/1193060753475688/1208652701561219/f

This PR updates the macOS exit survey to use a single platform for each message, and to only show the exit survey to those users who are <= 10 days away from expiration.

Testing steps:

To test this requires signing into a Privacy Pro account and then making some local tweaks to meet the criteria.

  1. Sign into a Privacy Pro account
  2. Update RemoteMessagingClient.swift to use the staging URL in debug mode
  3. Update the variables in RemoteMessagingConfigMatcherProvider to match what you want - in this case, set privacyProDaysUntilExpiry to 4, and privacyProPurchasePlatform to stripe (particularly important if you have an employee account, since it has a custom purchase platform)
  4. Finally, launch the app and use the debug menu to reset and refresh remote messages if needed
  5. If the message doesn't appear, it may be because you have interacted with it before, or interacted with the deprecated remote messaging feature - you can try and pass empty arrays for dismissedDeprecatedMacRemoteMessageIds and dismissedMessageIds in RemoteMessagingConfigMatcherProvider to get around this

Copy link

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @samsymons!

@samsymons samsymons merged commit 21eb791 into main Oct 30, 2024
1 check passed
@samsymons samsymons deleted the sam/show-privacy-pro-exit-survey-5-days-before-expiration branch October 30, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants