Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows 14 day survey #116

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Conversation

Jonathan-L
Copy link
Contributor

Added permeant 14 day survey for windows. This is active where

  • the install date is between 14 and 21 days
  • the locale is en-US, en-CA, en-GB or en-AU
  • the user is on app version 0.93.0
    • This is because there's a new survey parameter that's been added in 0.93.0
  • the user hasn't previously interacted with the old non RMF survey with value survey.dismissed

Don't merge this at the moment - since 0.93.0 has not been released to stable yet.

Copy link

github-actions bot commented Nov 4, 2024

@Jonathan-L Jonathan-L force-pushed the feature/jonathan/windows-14-day-survey branch from 83567da to 46af082 Compare December 20, 2024 15:28
@petevb petevb self-assigned this Dec 20, 2024
Copy link

@petevb petevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation

@Jonathan-L Jonathan-L requested a review from petevb December 20, 2024 16:41
Copy link

@petevb petevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@Jonathan-L Jonathan-L merged commit 10657cf into main Dec 22, 2024
1 check passed
@Jonathan-L Jonathan-L deleted the feature/jonathan/windows-14-day-survey branch December 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants