New message for privacy pro promotion with origin #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json |
samsymons
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
@amddg44 I wasn't able to get this message to appear correctly, it was failing to match the locale; after some debugging it turns out we only support an array of locale strings, rather than a single value.
I've pushed a commit to use an array, now it looks good to me:
samsymons
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit aabfc34.
samsymons
added a commit
that referenced
this pull request
Dec 11, 2024
Reverts #124 To test this, check the original PR and ensure that the correct changes are removed, and verify that the build number is bumped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm message conforms to specifications: https://app.asana.com/0/1204739911139421/1208278640816845/f
To test:
en_US, that you are not subscribed to privacy pro but that you are eligibleRemoteMessagingClient.swiftupdate the debug URL to use the staging URL from the github action below