-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Privacy Pro surveys to be US-only #128
Conversation
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/android-config.json |
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/macos-config.json |
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json |
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/windows-config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS & macOS LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android LGTM
Task: https://app.asana.com/0/1208524871249522/1208975663292694/f
This PR updates the Privacy Pro surveys for each platform to be US-only.
For each platform, check that the
locale
attribute is used correctly and only applied to the Privacy Pro surveys. Verify that no Privacy Pro surveys are still missing locale.